[Buildroot] [PATCH 05/13 v7] core/legal-info: add package version to license directory

Arnout Vandecappelle arnout at mind.be
Sat May 14 21:22:15 UTC 2016


On 05/13/16 22:11, Yann E. MORIN wrote:
> Thomas, All,
>
> On 2016-05-11 23:43 +0200, Thomas Petazzoni spake thusly:
>> On Sat, 7 May 2016 22:01:28 +0200, Arnout Vandecappelle wrote:
>>
>>>> +	@$$(call legal-warning-pkg,$$($(2)_RAW_BASE_NAME),cannot save license ($(2)_LICENSE_FILES not defined))
>>>
>>>   I think this should stay $(2)_RAWNAME, or either it should change as well for
>>> the legal-warning-source below.
>>>
>>>   Other than that:
>>> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>>
>> I agree with Arnout here (we should keep using $(2)_RAWNAME for the
>> warning). Yann, what do you think?
>
> 1. With this patch (and the following one), legal-info now gets saved in
>    sub-directories named after the paclage name and version, i.e.:
>
>     legal-info/licenses/pkg-version/
>     legal-info/sources/pkg-version/
>
> 2. With this patch, we also store the package name and version in the
>    manifest.
>
> 3. The warnings are stored in the legal-info report.
>
> So, I think it is better that the info about packages is the same
> everywhere: sources/ and licenses/ sub-dirs, entries in the manifest and
> warnings alike.

  I completely agree with this reasoning. Note that I wrote:

 >>>   [...] or either it should change as well for
 >>> the legal-warning-source below.


  Regards,
  Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list