[Buildroot] [PATCH 1/5] package/nginx: fix libxslt support

[Martin Bark]

Thomas,

On 13 May 2016 at 22:26, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Mon,  9 May 2016 12:28:59 +0100, Martin Bark wrote:
>> Change to using pkg-config to find libxslt and it dependencies.
>>
>> This Fixes:
>>  http://autobuild.buildroot.net/results/382699bbed15f598625b9296e464d1349ef559f8
>>
>> Signed-off-by: Martin Bark <martin at barkynet.com>
>> ---
>>  ...bxslt-conf-allow-to-override-ngx_feature_.patch | 42 ----------------------
>>  ...0004-auto-lib-libxslt-conf-use-pkg-config.patch | 31 ++++++++++++++++
>>  package/nginx/nginx.mk                             |  7 ++--
>>  3 files changed, 35 insertions(+), 45 deletions(-)
>>  delete mode 100644 package/nginx/0004-auto-lib-libxslt-conf-allow-to-override-ngx_feature_.patch
>>  create mode 100644 package/nginx/0004-auto-lib-libxslt-conf-use-pkg-config.patch
>
> I've applied your 5 patches to the master branch, thanks for doing this
> work around nginx, much appreciated.
>
> I have two comments though:
>
>  1/ Could you submit the nginx patches upstream? We currently have 8
>     patches on nginx, and it would be really good to reduce the size of
>     this stack of patches.

yes I'll work on that

>
>  2/ We normally don't number the patches on packages, i.e we don't want
>     the patches do have "PATCH x/y" in their title. Since the nginx
>     patches already had a numbering, I applied your patches as-is. But
>     as you can see now, this numbering is meaningless (which is why we
>     don't want it in the first place). A follow-up commit removing this
>     numbering would be good.

I have submitted a patch to correct this.  Thanks for letting me know,
I'll avoid that in the future.

Thanks

Martin

>
> Thanks again!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com