[Buildroot] [PATCH] Add support GLES/EGL for odroidc2 broads
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sun May 22 20:44:47 UTC 2016
Hello,
On Sun, 22 May 2016 19:45:59 +0200, daggs wrote:
> the following patch adds GLES/EGL support for odroidc2 broads.
> this means that programs like kodi which needs ui can be run.
Thanks for this patch! Great to see some OpenGL enabling on ARM64.
However, could you:
1/ Send your patch with git send-email so that the patch appears
inline and not as an attachment, which allows us to do proper review
of the patch.
2/ Split the patches in multiple patches? You need to at least
separate the following aspects:
a/ odroid-mali package addition
b/ kodi package changes
c/ odroidc2 changes
Note that in the odroid-mali package, you use variables like
INSTALL_LIBS, INSTALL_HDRS, etc. This is not a good idea, since the
namespace of variables in Buildroot is global. Due to this, *all*
variables defined by a package must be prefixed by the name of the
package.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list