[Buildroot] [PATCH] xserver_xorg-server: add explicit handling for xwayland

Peter Korsgaard peter at korsgaard.com
Tue May 24 15:43:14 UTC 2016


>>>>> "Gustavo" == Gustavo Zacarias <gustavo at zacarias.com.ar> writes:

 > It's normally autodetected, which can lead to unexpected/unhandled
 > results.
 > configure checks for libdrm, libepoxy and wayland, however a proper
 > libxcomposite check is missing thus it can lead to build failure under
 > some odd conditions.
 > There's no autobuilder failure to quote here, however there's a mailing
 > list post that exemplifies this:
 > http://lists.busybox.net/pipermail/buildroot/2016-May/161793.html

 > Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
 > ---
 >  package/x11r7/xserver_xorg-server/xserver_xorg-server.mk | 8 ++++++++
 >  1 file changed, 8 insertions(+)

 > diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
 > index 31f6d0d..69e9151 100644
 > --- a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
 > +++ b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
 > @@ -80,6 +80,14 @@ XSERVER_XORG_SERVER_CONF_OPTS += \
 >  	--disable-systemd-logind
 >  endif
 
 > +# Xwayland support needs libdrm, libepoxy, wayland and libxcomposite
 > +ifeq ($(BR2_PACKAGE_LIBDRM)$(BR2_PACKAGE_LIBEPOXY)$(BR2_PACKAGE_WAYLAND)$(BR2_PACKAGE_XLIB_LIBXCOMPOSITE),yyyy)
 > +XSERVER_XORG_SERVER_CONF_OPTS += --enable-wayland
 > +XSERVER_XORG_SERVER_DEPENDENCIES += libdrm libepoxy wayland xlib_libXcomposite

Thanks. Except for libepoxy (and wayland) these are just normal
libraries. Would it make sense to pull them in in Config.in:

E.G.:

        select BR2_PACKAGE_LIBDRM if BR2_PACKAGE_WAYLAND
        select BR2_PACKAGE_XLIB_LIBXCOMPOSITE if BR2_PACKAGE_WAYLAND

But ok, that can be done as a followup patch. Committed, thanks!

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list