[Buildroot] [PATCH] owfs: install python bindings in the correct location

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Nov 1 14:56:07 UTC 2016


Hello,

On Tue, 1 Nov 2016 15:51:09 +0100, Arnout Vandecappelle wrote:

> > Could we instead introduce a OWFS_MAKE_OPTS variable? Yes, that's a
> > slightly larger change, but it's our usual pattern to handle such
> > situations, so I'd prefer to have it handled like this in owfs as well.  
> 
>  You mean:
> 
> OWFS_MAKE_OPTS += PYSITEDIR=/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages
> 
> and then outside of the condition:
> 
> OWFS_MAKE = $(MAKE) $(OWFS_MAKE_OPTS)

Yes, considering what we have in the autotools package infrastructure
right now.

However, I find our usage of those variables in the infrastructure a
bit weird:

 - We use <pkg>_MAKE_OPTS only during the build

 - We use <pkg>_INSTALL_{TARGET,STAGING}_OPTS at install time, with a
   default value of DESTDIR=$(..._DIR) install, which has sometimes
   caused some issues as people forgot about it.

Maybe we should use <pkg>_MAKE_OPTS also at install time?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list