[Buildroot] [PATCH] owfs: install python bindings in the correct location

[Arnout Vandecappelle]

On 01-11-16 15:51, Arnout Vandecappelle wrote:
> 
> 
> On 01-11-16 15:36, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Tue, 1 Nov 2016 15:14:48 +0100, Arnout Vandecappelle
>> (Essensium/Mind) wrote:
>>
>>> +# The configure scripts finds PYSITEDIR as the python_lib directory of
>>> +# host-python, and then prepends DESTDIR in front of it. So we end up
>>> +# installing things in $(TARGET_DIR)/$(HOST_DIR)/usr/lib/python which is
>>> +# clearly wrong.
>>> +# Patching owfs to do the right thing is not trivial, it's much easier to
>>> +# override the PYSITEDIR variable in make. That, in turn, is easier to do by
>>> +# setting OWFS_MAKE, otherwise both OWFS_INSTALL_STAGING_OPTS and
>>> +# OWFS_INSTALL_TARGET_OPTS would have to be overridden
>>> +OWFS_MAKE = $(MAKE) PYSITEDIR=/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages
>>
>> Could we instead introduce a OWFS_MAKE_OPTS variable? Yes, that's a
>> slightly larger change, but it's our usual pattern to handle such
>> situations, so I'd prefer to have it handled like this in owfs as well.
> 
>  You mean:
> 
> OWFS_MAKE_OPTS += PYSITEDIR=/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages
> 
> and then outside of the condition:
> 
> OWFS_MAKE = $(MAKE) $(OWFS_MAKE_OPTS)

 It'll have to be something different from _MAKE_OPTS though, because _MAKE_OPTS
is already taken by the autotools package infra.

 Ideally, _MAKE_OPTS would be used in the autotools install commands as well.
However, _MAKE_OPTS is sometimes used to specify the target (e.g.
SETSERIAL_MAKE_OPTS = setserial) and sometimes to specify additional options
(e.g. TN5250_MAKE_OPTS = CPPFLAGS=""). So it'd have to be split up into a
_MAKE_OPTS and _MAKE_TARGET (and the existing _INSTALL_STAGING/TARGET_OPTS would
have to becom _TARGET as well).

 In short, what you're asking is not a trivial change :-)

 Regards,
 Arnout

> 
> ?
> 
>  Regards,
>  Arnout
> 
> 
>>
>> Thanks,
>>
>> Thomas
>>
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF