[Buildroot] [PATCH v2 05/23] toolchain-external-blackfin-uclinux: new package

[Romain Naour]

Hi Thomas,

Le 01/11/2016 à 14:19, Thomas Petazzoni a écrit :
> Hello,
> 
> On Sun, 30 Oct 2016 19:17:00 +0100, Yann E. MORIN wrote:
> 
>>> The virtual package should be named "toolchain-external", which clashes
>>> with the existing "toolchain-external" package that you remove in step
>>> (5). So you can't do your step (2) before doing your step (5), unless
>>> of course you name the packages differently.  
>>
>> A virtual package is but a generic package, so nothing prevents it from
>> having its own _CMDS macros; it can download, configure and build stuff
>> of its own.
>>
>> Alternatively, you can have the toolchain-external package depend on
>> each of the new toochain-external-foo when it is added, as a kind of
>> manually-handled virtual package, before eventually converting it to a
>> real virtual package once everything as been split out to individual
>> providers.
> 
> So when the series if half applied, you have:
> 
>  - The toolchain-external package infrastructure, which is used by some
>    of the toolchains
> 
>  - The toolchain-external package, which depending on the toolchain,
>    either:
> 
>    - Implements itself the logic (for toolchains not yet converted)
> 
>    - Depends on another package, toolchain-external-foo, that
>      uses the toolchain-external package infrastructure ?
> 
> So at some point, if you have two times the code to handle the external
> toolchain logic. But I agree that this can work.
> 
> Romain, what do you think?

I think we should decide if we really want this series before -rc1 or delay it
for -next.
If we want this series for -rc1, I might not have finished the rework on time.
If not, I can take the time to rework with Yann's proposal.

Best regards,
Romain