[Buildroot] [PATCH next] olimex_imx233_olinuxino: split defconfig in 2 variants
François Perrad
francois.perrad at gadz.org
Sat Nov 12 14:09:51 UTC 2016
2016-11-12 13:17 GMT+01:00 Fabio Estevam <festevam at gmail.com>:
> On Sat, Nov 12, 2016 at 7:04 AM, Francois Perrad <fperrad at gmail.com> wrote:
>> Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
>
> It would be nice to explain the reason for splitting the defconfigs in
> the commit log.
>
>
>> ---
>> DEVELOPERS | 2 ++
>> board/olimex/imx233_olinuxino/readme.txt | 38 +++++++++++++++++++---
>> ...nfig => olimex_imx233_olinuxino_maxi_defconfig} | 16 +--------
>> ...=> olimex_imx233_olinuxino_mini_wifi_defconfig} | 3 +-
>> 4 files changed, 37 insertions(+), 22 deletions(-)
>> copy configs/{olimex_imx233_olinuxino_defconfig => olimex_imx233_olinuxino_maxi_defconfig} (66%)
>> rename configs/{olimex_imx233_olinuxino_defconfig => olimex_imx233_olinuxino_mini_wifi_defconfig} (97%)
>>
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index 3a9c00d..60dd82c 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -496,7 +496,9 @@ F: package/ser2net/
>
> This should be a separate patch.
You are right according
https://buildroot.org/downloads/manual/manual.html#submitting-patches.
>>
>> N: Francois Perrad <francois.perrad at gadz.org>
>> F: board/olimex/a20_olinuxino
>> +F: board/olimex/imx233_olinuxino
>> F: configs/olimex_a20_olinuxino_*
>> +F: configs/olimex_ims233_olinuxino_*
>
> ims233 ?
Yes, typo imx233
>
> I don't see the value in doing this splitting.
>
> What is the problem it fixes or what advantage it brings?
My rational is:
- The Wifi part is annoying for me because I cannot test it.
- olimex_imx233_olinuxino_maxi_defconfig is really as minimal as possible
(see policy in https://buildroot.org/downloads/manual/manual.html#adding-board-support)
and I could maintain (and test) it.
François
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
More information about the buildroot
mailing list