[Buildroot] [PATCH v2,1/2] cjson: bump to version v1.0.1
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Mon Nov 21 22:21:21 UTC 2016
Hello,
On Sun, 20 Nov 2016 18:22:24 +0100, Fabrice Fontaine wrote:
> Signed-off-by: Fabrice Fontaine <fabrice.fontaine at orange.com>
An empty commit log for something that is clearly not a bump is not
good. You should explain that the project site has moved, why
BR2_STATIC_LIBS is OK, that it has changed to use cmake, etc.
Also your PATCH 2/2, also if it affects another package, should be
merged into PATCH 1/2. Indeed, if I ever apply PATCH 1/2 but not PATCH
2/2, tinycbor will not build.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list