[Buildroot] [PATCH/next] toolchain-external: support gcc < 4.3

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Nov 24 08:01:08 UTC 2016


Hello,

On Thu, 24 Nov 2016 00:38:33 +0100, Arnout Vandecappelle wrote:
> On 23-11-16 23:21, Thomas Petazzoni wrote:
> [snip]
> >> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> >> index 3991bc1..72e7292 100644
> >> --- a/toolchain/helpers.mk
> >> +++ b/toolchain/helpers.mk
> >> @@ -145,8 +145,7 @@ check_kernel_headers_version = \
> >>  check_gcc_version = \
> >>  	expected_version="$(strip $2)" ; \
> >>  	if [ -z "$${expected_version}" ]; then \
> >> -		printf "Internal error, gcc version unknown (no GCC_AT_LEAST_X_Y selected)\n"; \
> >> -		exit 1 ; \
> >> +		exit 0 ; \  
> > 
> > Why?  
> 
>  As stated in the commit log:
> 
> When [BR2_TOOLCHAIN_GCC_AT_LEAST] is
> empty, we don't do a version check at all in check_gcc_version.
> 
>  Perhaps I should add to that "(previously we errored out)".

Well, we're still erroring out, but with a 0 exit code. So I must be
missing something.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list