[Buildroot] [PATCH next 4/6] moarvm: select libffi when building for MIPS

Vicente Olivert Riera Vincent.Riera at imgtec.com
Thu Nov 24 17:50:36 UTC 2016


Hi Thomas,

On 24/11/16 16:54, Thomas Petazzoni wrote:
> Hello,
> 
> On Thu, 24 Nov 2016 16:23:46 +0000, Vicente Olivert Riera wrote:
> 
>> no, there is no patch enabling or disabling MoarVM for MIPS. You won't
>> be able to build MoarVM for MIPS until libatomic_ops has support for
>> MIPS as well, because MoarVM depends on libatomic_ops.
>>
>> So, if we enable libatomic_ops, then we will be able to build MoarVM,
>> and that will fail. What I did in my patch series is to add the code for
>> fixing the MIPS problem in MoarVM even before we can actually build it
>> for MIPS.
> 
> Ah, yes, moarvm has a "depends on
> BR2_PACKAGE_LIBATOMIC_OPS_ARCH_SUPPORTS", so indeed moarvm can't be
> selected for MIPS until MIPS support in libatomic_ops is enabled. So
> bisectability-wise we are OK.
> 
> However, from a logical point of view, it is very, very strange to
> enable the dependencies of moarvm *after* moarvm itself.

That's the thing, we are not enabling moarvm itself. It happens
automatically when you enable its dependencies.

> It would be
> much more logical to take care of libatomic_ops first (which can be
> used for other things than moarvm), and then handle moarvm.

Yeah, I see your point. The thing is that I put first the fix for moarvm
in place so whenever it gets enabled for MIPS it's gonna build just fine.

Anyway, do you need me to resend this series with the patches in
different order, or will you handle that when applying?

Regards,

Vincent

> 
> Thanks,
> 
> Thomas
> 



More information about the buildroot mailing list