[Buildroot] [PATCH 06/51] ed: use $(TARGET_MAKE_ENV) when calling $(MAKE)

[Arnout Vandecappelle]

[I'm sorry for reviewing this in pieces...]

On 14-10-16 16:45, Arnout Vandecappelle wrote:
> 
> 
> On 14-10-16 16:41, Arnout Vandecappelle wrote:
>>
>>
>> On 14-10-16 00:13, gustavo.zacarias at free-electrons.com wrote:
>>> From: Gustavo Zacarias <gustavo.zacarias at free-electrons.com>
>>>
>>> Signed-off-by: Gustavo Zacarias <gustavo.zacarias at free-electrons.com>
[snip]
>>> diff --git a/package/ed/ed.mk b/package/ed/ed.mk
>>> index f3bcb74..101be0e 100644
>>> --- a/package/ed/ed.mk
>>> +++ b/package/ed/ed.mk
>>> @@ -21,11 +21,11 @@ define ED_CONFIGURE_CMDS
>>>  endef

 ED_CONFIGURE_CMDS should also get TARGET_MAKE_ENV. It does already get
TARGET_CONFIGURE_OPTS, but only as arguments to configure and as far as I can
see that script doesn't load the assignment arguments in its environment.
Admittedly, the configure script doesn't try to compile anything so it's not
strictly needed to export the corrected staging dir, but for consistency it
would be better to pass it anyway.

 Regards,
 Arnout

>>>  
>>>  define ED_BUILD_CMDS
>>> -	$(MAKE)	-C $(@D)
>>> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
>>>  endef
>>>  
>>>  define ED_INSTALL_TARGET_CMDS
>>> -	$(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
>>> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
>>>  endef
>>>  
>>>  $(eval $(generic-package))
>>>
>>
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF