[Buildroot] [PATCH 2/2] odroid-mali: add support for X11 driver

Arnout Vandecappelle arnout at mind.be
Sat Oct 15 08:28:21 UTC 2016


 I'm CC'ing Gary here because the same issues exist for Vivante, which uses a
slightly different approach. Gary, can you comment if you think this is a good
approach?

On 15-10-16 07:57, daggs wrote:
> 
> Greetings Arnout, 
>>  The Vivante driver has a similar issue as this one: there are different binary
>> blobs for X11 and for fbdev, and only one of them can be installed. For the
>> Vivante driver, we offer a choice to the user, and the x11-video driver depends
>> on the user making the right choice. I don't really like that option. However,
>> this one is not ideal either, because there is a two-way interdependence between
>> the odroid-mali and the xdriver-video package. In fact, the way it is now, the
>> two patches have to be squashed because the previoius one doesn't work without
>> this one.
>>
>>  So here is my idea: introduce a blind symbol BR2_PACKAGE_ODROID_MALI_X11 in
>> this package, and let that option steer the choice between X11 or fbdev. It's
>> blind, it's not part of a choice, so it can be selected from the xdriver-video
>> package. So from the user's POV, they just have to select the xdriver-video
>> package and not worry about the rest. This way, you can first have this patch,
>> and then add the xdriver-video package in a second patch.
>>
>>
> thanks for the feedback, this driver has some limitations, the X11 opengl libs supports only arm64. there is no implementation for arm.
> I want to see if I got the idea correct, as said, add the symbol mentioned above:
> 1) arm: show only the fbdev as an option, the current implementation stays the same. the X11 driver is hidden.

 The X11 option would always be hidden. So:

config BR2_PACKAGE_ODROID_MALI_X11
	bool
	depends on BR2_aarch64 # No 32 bit version available

and in the xvideo package:

	depends on BR2_aarch64 # odroid-mali X11
	select BR2_PACKAGE_ODROID_MALI
	select BR2_PACKAGE_ODROID_MALI_X11

> 2) arm54: show fbdev and X11 option (if xorg + drivers is set), if fbdev is selected use the current implementation. if the X11 driver is selected, use the implementation in the patch.

 Yes, except that it wouldn't be a user-visible option.

 I don't think it makes sense to make the option user visible, because you
anyway need another package to make use of it, and it's very unlikely that that
will be a custom package for X11. So whatever package makes use of it can select
the symbol.

 There should be some help text in odroid-mali to explain that the X11 version
of the blob will be used if the xvideo driver is selected.

 Regards,
 Arnout


> am I correct?
> 
> Dagg.
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list