[Buildroot] [PATCH 2/2] odroid-mali: add support for X11 driver

Gary Bisson gary.bisson at boundarydevices.com
Sat Oct 15 09:55:19 UTC 2016


Arnout, All,

On Sat, Oct 15, 2016 at 10:28 AM, Arnout Vandecappelle <arnout at mind.be> wrote:
>  I'm CC'ing Gary here because the same issues exist for Vivante, which uses a
> slightly different approach. Gary, can you comment if you think this is a good
> approach?
>
> On 15-10-16 07:57, daggs wrote:
>>
>> Greetings Arnout,
>>>  The Vivante driver has a similar issue as this one: there are different binary
>>> blobs for X11 and for fbdev, and only one of them can be installed. For the
>>> Vivante driver, we offer a choice to the user, and the x11-video driver depends
>>> on the user making the right choice. I don't really like that option. However,
>>> this one is not ideal either, because there is a two-way interdependence between
>>> the odroid-mali and the xdriver-video package. In fact, the way it is now, the
>>> two patches have to be squashed because the previoius one doesn't work without
>>> this one.
>>>
>>>  So here is my idea: introduce a blind symbol BR2_PACKAGE_ODROID_MALI_X11 in
>>> this package, and let that option steer the choice between X11 or fbdev. It's
>>> blind, it's not part of a choice, so it can be selected from the xdriver-video
>>> package. So from the user's POV, they just have to select the xdriver-video
>>> package and not worry about the rest. This way, you can first have this patch,
>>> and then add the xdriver-video package in a second patch.
>>>
>>>
>> thanks for the feedback, this driver has some limitations, the X11 opengl libs supports only arm64. there is no implementation for arm.
>> I want to see if I got the idea correct, as said, add the symbol mentioned above:
>> 1) arm: show only the fbdev as an option, the current implementation stays the same. the X11 driver is hidden.
>
>  The X11 option would always be hidden. So:
>
> config BR2_PACKAGE_ODROID_MALI_X11
>         bool
>         depends on BR2_aarch64 # No 32 bit version available
>
> and in the xvideo package:
>
>         depends on BR2_aarch64 # odroid-mali X11
>         select BR2_PACKAGE_ODROID_MALI
>         select BR2_PACKAGE_ODROID_MALI_X11

I like this approach, I wish we could do the same for Vivante. In
Vivante's case it is not possible since the package depends on the SoC
version (BR2_PACKAGE_FREESCALE_IMX_PLATFORM) which cannot be selected.

>> 2) arm54: show fbdev and X11 option (if xorg + drivers is set), if fbdev is selected use the current implementation. if the X11 driver is selected, use the implementation in the patch.
>
>  Yes, except that it wouldn't be a user-visible option.

This will therefore avoid any confusion about which library to use and
ease support questions. My opinion is to go for it if you can.

Regards,
Gary



More information about the buildroot mailing list