[Buildroot] [PATCH 00/93] TLP/PPS: package cleanup part 2

Arnout Vandecappelle arnout at mind.be
Tue Oct 18 22:04:02 UTC 2016



On 17-10-16 18:05, gustavo.zacarias at free-electrons.com wrote:
> From: Gustavo Zacarias <gustavo.zacarias at free-electrons.com>
> 
> This patchset takes over from the first round of cleanup.
> 
> It takes into account feedback on the patches that weren't applied for
> the previous set and addressed them, like setting the proper host env
> for host packages and other steps like configure and install for target
> packages.

 I reviewed the series, posted comments on some, and the ones that can go in
have been added to a bundle:

http://patchwork.ozlabs.org/bundle/arnout/gustavoz_target_make_env_2/

 However, please first consider the question I asked in the cryptopp patch:

HOST_CONFIGURE_OPTS already contains HOST_MAKE_ENV, so if
HOST_CONFIGURE_OPTS is passed as the argument to MAKE, does it still make sense
to pass it in the environment as well?

 I haven't marked the remaining ones as Changes Requested yet, that's a lot
easier to do once the bundle has been merged. Oh, Thomas, there's really no need
to manually add my Reviewed-by everywhere...


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list