[Buildroot] [PATCH 0/6] xorg: fix imput drivers install paths

Peter Korsgaard peter at korsgaard.com
Tue Oct 25 11:25:54 UTC 2016


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > Hello All!
 > This series fixes the install paths of the few remaining input drivers
 > that incorrectly installed headers in $(TARGET_DIR)/$(STAGING_DIR).

 > The underlying issue is that xorg defines an "sdkdir" pkg-config
 > variable, as the location to find/install headers. This location is an
 > absolute path to the staging dir (aka sysroot), but headers are
 > installed in $(DESTDIR)/$(sdkdir).

 > We fix that by entirely ditching the use of sdkdir, as was done in all
 > other xorg dirvers, with the 5 first patches of the series.

Sounds sensible to me. Did you try proposing the patches upstream?

 > Additionally, to catch such situation, the 6th and last patch of the
 > series checks no such paths are present, neither in target/ nor in
 > staging/ .

This seems to overlap with the checks Samuel is adding,
E.G. TARGET_DIR/STAGING_DIR are subdirs of the host build directory, so
that check should catch these issues as well.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list