[Buildroot] [PATCH 02/30] toolchain-external: pass CC and CFLAGS as arguments

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Oct 25 11:44:11 UTC 2016


Hello,

On Tue, 25 Oct 2016 13:07:01 +0200, Arnout Vandecappelle wrote:

>  This is exactly the same commit message as the previous commit. However, what
> this patch actually does is
> 
> 1. Pass up CC and CFLAGS one level more
>  -> I think this should be squashed with the previous commit.  
> 
> 2. pass LIBS as arguments
>  -> This should be a separate commit, with the appropriate commit message.  

I believe Romain's idea is to split this per *function* (or family
of functions) being changed, not per arguments being passed. So indeed,
the wording of his commit titles and logs is not very good. It should
have been:

 toolchain-external: TOOLCHAIN_EXTERNAL_CREATE_*_LIB_SYMLINK: use arguments instead of global variables
 toolchain-external: TOOLCHAIN_EXTERNAL_INSTALL_*_LIBS: use arguments instead of global variables
 toolchain-external: TOOLCHAIN_EXTERNAL_INSTALL_WRAPPER: use arguments instead of global variables
 toolchain-external: TOOLCHAIN_EXTERNAL_INSTALL_TARGET_GDBSERVER: use arguments instead of global variables

I find this split a lot more logical than a split by argument being
added, as the latter would mean a given function gets modified in two
different patches.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list