[Buildroot] [PATCH 4/5] lttng-modules: bump to version 2.8.3

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Oct 30 16:15:53 UTC 2016


Hello,

On Sat, 29 Oct 2016 14:03:38 -0400, Philippe Proulx wrote:
> Signed-off-by: Philippe Proulx <eeppeliteloop at gmail.com>

Again, the commit log is empty, even though the patch is doing much
more than a bump to 2.8.3.

> +LTTNG_MODULES_DEPENDENCIES = linux
> +
> +ifeq ($(BR2_PACKAGE_LTTNG_MODULES),y)
> +LINUX_NEEDS_MODULES = y
> +endif
> +
> +LTTNG_MODULES_MAKE_OPTS = \
> +	KERNELDIR="$(LINUX_DIR)" \
> +	ARCH="$(KERNEL_ARCH)" \
> +	CROSS_COMPILE="$(TARGET_CROSS)"
> +
> +define LTTNG_MODULES_BUILD_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) $(LTTNG_MODULES_MAKE_OPTS) -C $(@D)
> +endef
> +
> +define LTTNG_MODULES_INSTALL_STAGING_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) $(LTTNG_MODULES_MAKE_OPTS) \
> +		INSTALL_MOD_PATH="$(STAGING_DIR)" -C $(@D) modules_install
> +endef
> +
> +define LTTNG_MODULES_INSTALL_TARGET_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) $(LTTNG_MODULES_MAKE_OPTS) \
> +		INSTALL_MOD_PATH="$(TARGET_DIR)" -C $(@D) modules_install
> +endef
>  
> -$(eval $(kernel-module))

Why do you stop using the kernel-module infrastructure? This should
definitely be explained in the commit log.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list