[Buildroot] [PATCH] gst1-rtsp-server: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Sep 8 21:30:19 UTC 2016


Hello,

On Fri, 2 Sep 2016 18:23:41 +0530, Abhilash Tuse wrote:
> From: Piotr Nakraszewicz <piotr.nakraszewicz at imgtec.com>
> 
> Based on patch by Phil Edworthy:
> http://lists.busybox.net/pipermail/buildroot/2010-June/035777.html
> 
> Reviewed-by: Rahul Bedarkar <rahul.bedarkar at imgtec.com>
> Reviewed-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma at imgtec.com>
> Signed-off-by: Piotr Nakraszewicz <piotr.nakraszewicz at imgtec.com>
> Signed-off-by: Abhilash Tuse <Abhilash.Tuse at imgtec.com>

Thanks for your patch! I have two comments, see below.


> diff --git a/package/gstreamer1/gst1-rtsp-server/Config.in b/package/gstreamer1/gst1-rtsp-server/Config.in
> new file mode 100644
> index 0000000..5201a8d
> --- /dev/null
> +++ b/package/gstreamer1/gst1-rtsp-server/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_GST1_RTSP_SERVER
> +	bool "gst1-rtsp-server"
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE
> +	select BR2_PACKAGE_GST1_PLUGINS_BAD
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD

Are you sure all of these are mandatory? From a quick look at the
configure.ac script, they don't seem to be mandatory, but rather be
optional dependencies. Have you tested a build with just
gstreamer1+gst1-rtsp-server ? If it works, then they are indeed
optional dependencies, in which case you want to remove those "select"
here, and instead in the .mk file do:

ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE),y)
GST1_RTSP_DEPENDENCIES += gst1-plugins-base
endif

> +++ b/package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# gst1-rtsp-server
> +#
> +################################################################################
> +
> +GST1_RTSP_SERVER_VERSION = 1.8.3
> +GST1_RTSP_SERVER_SOURCE = gst-rtsp-server-$(GST1_RTSP_SERVER_VERSION).tar.xz
> +GST1_RTSP_SERVER_SITE = http://gstreamer.freedesktop.org/src/gst-rtsp-server
> +GST1_RTSP_SERVER_LICENSE = LGPLv2+
> +GST1_RTSP_SERVER_LICENSE_FILES = COPYING COPYING.LIB
> +GST1_RTSP_SERVER_INSTALL_STAGING = YES
> +GST1_RTSP_SERVER_DEPENDENCIES = gstreamer1 gst1-plugins-base gst1-plugins-bad gst1-plugins-good

In addition, libcgroup is an optional dependency of gst1-rtsp-server,
so:

ifeq ($(BR2_PACKAGE_LIBCGROUP),y)
GST1_RTSP_SERVER_DEPENDENCIES += libcgroup
endif

would be nice to have.

Could you look into these and send an updated patch? The rest of the
patch looks good.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list