[Buildroot] [autobuild.buildroot.net] Your build results for 2016-09-05

[Romain Naour]

Hi Thomas, Waldemar,

Le 06/09/2016 à 08:30, Thomas Petazzoni a écrit :
> Hello,
> 
> This is the list of Buildroot build failures that occured on
> 2016-09-05, and for which you are a registered architecture developer
> or package developer. Please help us improving the quality of
> Buildroot by investigating those build failures and sending patches to
> fix them. Thanks!
> 
> Build failures related to your packages:
> 
>         bfin |                  xenomai-2.6.4 | http://autobuild.buildroot.net/results/fcae0611ac87204ab68d6828276b635d1a31a178
> 

I think it's an issue between uClibc-ng and Xenomai on Blackfin due to
pthread_atfork(), shm_open() and shm_unlink() local definition in Xenomai.

Error:
bind.c:(.text+0x20): multiple definition of `pthread_atfork'
.libs/libxenomai_la-assert_context.o:assert_context.c:(.text+0x54): first
defined here

sem_heap.c:(.text+0xc): multiple definition of `shm_open'
.libs/libxenomai_la-bind.o:bind.c:(.text+0x2c): first defined here

sem_heap.c:(.text+0x24): multiple definition of `shm_unlink'
.libs/libxenomai_la-bind.o:bind.c:(.text+0x44): first defined here

It's because the Xenomai definition use declare these function as "inline" and
not uClibc-ng

Xenomai [1]:
/* uClibc does not provide pthread_atfork() for this arch; provide it
   here. Note: let the compiler decides whether it wants to actually
   inline this routine, i.e. do not force always_inline. */
inline __attribute__((weak)) int pthread_atfork(void (*prepare)(void),
						void (*parent)(void),
						void (*child)(void))

uClibc-ng:
extern int pthread_atfork (void (*__prepare) (void),
			   void (*__parent) (void),
			   void (*__child) (void)) __THROW;

I guess those "inline" should be removed?
Weldemar what do you think?

Best regards,
Romain

[1] xenomai/include/asm-blackfin/syscall.h