[Buildroot] [PATCH] core: distclean is a noconfig target

[Yann E. MORIN]

Thomas, All,

On 2016-09-11 15:34 +0200, Thomas Petazzoni spake thusly:
> On Sun, 11 Sep 2016 14:56:38 +0200, Yann E. MORIN wrote:
> > @@ -86,7 +86,7 @@ export BR2_VERSION_FULL := $(BR2_VERSION)$(shell $(TOPDIR)/support/scripts/setlo
> >  noconfig_targets := menuconfig nconfig gconfig xconfig config oldconfig randconfig \
> >  	defconfig %_defconfig allyesconfig allnoconfig silentoldconfig release \
> >  	randpackageconfig allyespackageconfig allnopackageconfig \
> > -	print-version olddefconfig
> > +	print-version olddefconfig distclean
> 
> The distclean target uses the DL_DIR variable, which is derived from
> BR2_DL_DIR, which can come from either the environment... or the
> configuration file. So, the BR2_DL_DIR from the configuration will be
> ignored. I'm not sure what the consequence is, but it's worth thinking
> about this.

Well, if either is set on not the default, then it is currently not
removed.

With this change, however, it is no longer removed, indeed.

But, why are we even having this removal conditional? We can just
unconditionally remove $(TOPDIR)/dl and be done with that, no?

> Also, what is the rationale for having just "distclean" and not "clean"
> in noconfig_targets ? The fact that "distclean" remove the
> configuration, and as such "helps" in solving configuration issues ?

Exactly.

Otherwise one has to manually remove the .config file, which is not
very nice...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'