[Buildroot] [PATCH] package/kvm-unit-tests: new package

Peter Korsgaard peter at korsgaard.com
Mon Sep 19 21:07:01 UTC 2016


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > Hello,
 > On Thu, 18 Aug 2016 09:02:36 +1000, Cyril Bur wrote:
 >> The unit tests are tiny guest operating systems that generally execute
 >> only tens of lines of C and assembler test code in order to obtain its
 >> PASS/FAIL result. Unit tests provide KVM and virt hardware functional
 >> testing by targeting the features through minimal implementations of
 >> their use per the hardware specification. The simplicity of unit tests
 >> make them easy to verify they are correct, easy to maintain, and easy
 >> to use in timing measurements. Unit tests are also often used for
 >> quick and dirty bug reproducers. The reproducers may then be kept as
 >> regression tests. It's strongly encouraged that patches implementing
 >> new KVM features are submitted with accompanying unit tests.
 >> http://www.linux-kvm.org/page/KVM-unit-tests
 >> 
 >> Signed-off-by: Cyril Bur <cyrilbur at gmail.com>
 >> ---
 >> package/Config.in                        |  1 +
 >> package/kvm-unit-tests/Config.in         | 17 ++++++++++++
 >> package/kvm-unit-tests/kvm-unit-tests.mk | 45 ++++++++++++++++++++++++++++++++
 >> 3 files changed, 63 insertions(+)
 >> create mode 100644 package/kvm-unit-tests/Config.in
 >> create mode 100644 package/kvm-unit-tests/kvm-unit-tests.mk

 > Applied to master with the following changes:

 >     [Thomas:
 >      - order architecture dependencies in Config.in alphabetically.
 >      - rewrap Config.in help text, lines were too long
 >      - add an empty line between the package description and the upstream
 >        project URL in the Config.in help text
 >      - don't make KVM_UNIT_TESTS_ARCH default to $(ARCH). This was not
 >        correct for i386 for example. Instead, just handle the few
 >        architectures that the package supports.
 >      - remove useless double quotes in variable definitions.
 >      - remove --prefix="$(TARGET_DIR)" from CONF_OPTS. It was installing
 >        everything in /share/ and not /usr/share/, and setting the prefix to
 >        TARGET_DIR at configure time is not good. Instead, pass DESTDIR at
 >        installation time.]

It unfortunately fails on x86-64:
http://autobuild.buildroot.org/results/445/4453e8001406a658ae4dc58448baaceb6d93cbf1/

As it contains 32bit code and our toolchains (normally) aren't
multilib. I guess we need to build those parts using the host compiler
and depend on BR2_HOSTARCH_NEEDS_IA32_COMPILER like we do for
grub/syslinux.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list