[Buildroot] [PATCH v4 02/39] package/libdvdread: add Kodi-specific patches

[Thomas Petazzoni]

Hello,

On Thu, 23 Mar 2017 18:28:23 +0100, Bernd Kuhls wrote:

> +# enable Kodi-specific code
> +ifeq ($(BR2_PACKAGE_KODI),y)
> +LIBDVDREAD_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -D_XBMC"
> +endif

This really feels clunky (ditto in patch 03/39). Why does the Kodi
related code needs to be conditional?

What if libdvdread is used in the same system for Kodi and for
something else?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com