[Buildroot] [PATCH 2/3] package/pngquant: new package

[Thomas Petazzoni]

Hello,

On Sat,  8 Apr 2017 17:18:03 +0200, Bernd Kuhls wrote:

> +define HOST_PNGQUANT_CONFIGURE_CMDS
> +	(cd $(@D) && \
> +		$(HOST_CONFIGURE_OPTS) \
> +		./configure --prefix=/usr \

--prefix=/usr is not correct for host packages, it should be
--prefix=$(HOST_DIR)/usr.

> +define HOST_PNGQUANT_INSTALL_CMDS
> +	$(HOST_MAKE_ENV) $(MAKE) PREFIX="$(HOST_DIR)/usr" -C $(@D) install

Then passing PREFIX= here becomes useless.

> +define PNGQUANT_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) PREFIX="$(TARGET_DIR)/usr" -C $(@D) install

And here passing DESTDIR=$(TARGET_DIR) makes more sense, since
--prefix=/usr is passed at configuration time.

I've fixed this, and grouped together the host configure/build/install
commands, and then applied.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com