[Buildroot] [PATCH 1/3 v2] core/pkg-generic: rmove intermediate file-list files

Arnout Vandecappelle arnout at mind.be
Mon Apr 10 14:23:58 UTC 2017



On 10-04-17 16:21, Arnout Vandecappelle wrote:
>  s/rmove/remove/
> 
> On 05-04-17 23:20, Yann E. MORIN wrote:
>> To compute the list of files added by a package, we first store the list
>> of files before the install, do the install, list the files after the
>> install, and finally compare the two lists. The two lists are stored in
>> dot-files, hidden in the package's build dir.
>>
>> We currently keep those two files, and only list the files installed in
>> target/
>>
>> In followup patches, we'll also list files installed in staging/ as well
>> as files installed in host/.
>>
>> Rather than add even more internal, hidden files in the package build
>> dir, we'll just re-use the same two temporary files to store the bfore
>                                                                     ^e
>> and after lists.
> 
>  Actually, I like to have as much as possible build info lingering around, so
> I'd tend not to do this removal and instead rename to something with 'target' in
> it. For example, I think we have no other way at the moment to detect when two
> packages write the same file. 

 D'oh, the file will of course simply appear twice in packages-file-list if two
packages write it... Silly me.

 Regards,
 Arnout


> IMO having internal hidden files in the package
> build dir doesn't hurt anyone. I certainly do like the applied patches list!
> 
>  That said, I don't see any other reason to keep those files, and we probably
> want explicit support for detecting collisions, so I'm OK with removing them
> after all.
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list