[Buildroot] [PATCH v2] package/aubio: bump to version 0.4.5
Romain Naour
romain.naour at gmail.com
Mon Apr 17 13:50:24 UTC 2017
Hi Thomas,
Le 17/04/2017 à 15:07, Thomas Petazzoni a écrit :
> Hello,
>
> On Sun, 16 Apr 2017 22:51:06 +0200, Romain Naour wrote:
>
>> -ifeq ($(BR2_PACKAGE_LIBSAMPLERATE),y)
>> +ifeq ($(BR2_PACKAGE_AUBIO_LIBSAMPLERATE),y)
>
> Since none of the other optional dependencies have a sub-option in this
> package, what about just:
>
> ifeq ($(BR2_PACKAGE_LIBSAMPLERATE)$(BR2_PACKAGE_FFTW_PRECISION_SINGLE),yy)
Yes, I hesitated by doing so but I thought it was better to handle the
dependency from Config.in (for the help text and comment when not available).
I've not a strong opinion.
>
> Also, I don't quite understand your commit, because libsamplerate is
> itself built with --disable-fftw.
humm, I don't really know if libsamplerate without fftw support can really work
with aubio. The build systemd doesn't check if fftw is enabled in libsamplerate.
I'll ask upstream.
Best regards,
Romain
>
> Thanks,
>
> Thomas
>
More information about the buildroot
mailing list