[Buildroot] [PATCH v2] package/aubio: bump to version 0.4.5

Romain Naour romain.naour at gmail.com
Mon Apr 17 17:25:44 UTC 2017


Hi Thomas,

Le 17/04/2017 à 15:50, Romain Naour a écrit :
> Hi Thomas,
> 
> Le 17/04/2017 à 15:07, Thomas Petazzoni a écrit :
>> Hello,
>>
>> On Sun, 16 Apr 2017 22:51:06 +0200, Romain Naour wrote:
>>
>>> -ifeq ($(BR2_PACKAGE_LIBSAMPLERATE),y)
>>> +ifeq ($(BR2_PACKAGE_AUBIO_LIBSAMPLERATE),y)
>>
>> Since none of the other optional dependencies have a sub-option in this
>> package, what about just:
>>
>> ifeq ($(BR2_PACKAGE_LIBSAMPLERATE)$(BR2_PACKAGE_FFTW_PRECISION_SINGLE),yy)
> 
> Yes, I hesitated by doing so but I thought it was better to handle the
> dependency from Config.in (for the help text and comment when not available).
> I've not a strong opinion.
> 
>>
>> Also, I don't quite understand your commit, because libsamplerate is
>> itself built with --disable-fftw.

As reported by Paul Brossier [1], fftw is not used by libsamplerate library.
Only tests programs use it.

So we just have to make sure that fftw use single precision mode when
libsamplerate is enabled [2].

Best regards,
Romain

[1] https://github.com/aubio/aubio/issues/100
[2] https://github.com/aubio/aubio/commit/8be88e77f5c275fdf4efc99ae182d14940948786

> 
> humm, I don't really know if libsamplerate without fftw support can really work
> with aubio. The build systemd doesn't check if fftw is enabled in libsamplerate.
> I'll ask upstream.
> 
> Best regards,
> Romain
> 
>>
>> Thanks,
>>
>> Thomas
>>
> 




More information about the buildroot mailing list