[Buildroot] [PATCH] package/xen: Use POSIX complaint header includes

[Alistair Francis]

On Tue, Apr 18, 2017 at 1:09 AM, Arnout Vandecappelle <arnout at mind.be> wrote:
>
>
> On 18-04-17 10:04, Arnout Vandecappelle wrote:
>>
>>
>> On 18-04-17 05:35, Baruch Siach wrote:
>>> Hi Alistair,
>>>
>>> On Mon, Apr 17, 2017 at 04:14:57PM -0700, Alistair Francis wrote:
>>>> To fix build issues when using the musl library use POSIX compatible
>>>> library inclues.
>>>
>>> Is there any build failure or run time issue that these patches are fixing?
>>>
>>> It would be nice to have build warnings dealt with upstream to have a clean
>>> build. But Buildroot doesn't carry patches for the sole purpose of fixing
>>> build time warnings.
>>
>>  +1 to that.
>>
>>> When build warnings break the build because of -Werror, we either add
>>> -Wno-error, or patch out the -Werror to fix the build.
>>
>>  But not to this. A fundamental solution with an upstreamable patch is better,
>> -Wno-error is rather a stopgap measure when avoiding warnings is too difficult.
>> Which is often the case, by the way, e.g. if upstream haven't tested their code
>> yet with GCC 7.
>>
>>
>>  So, if this patch fixes a build or runtime failure, please mention this in the
>> commit message; if not, please mark the patch as Rejected in patchwork (but do
>> send it upstream, of course!).
>
>  So I checked myself, it does have an autobuild failure. Please add this to the
> commit log:
>
> Fixes:
> http://autobuild.buildroot.net/results/1aa/1aa1303f60372f51aa5a7eb18caac4a5b5c1d9d4/build-end.log

Thanks for the review.

Sorry I should have mentioned that this fixes a autobuild issue which
you already found.

>
>  And also, show that you have submitted is upstream:
>
> Submitted upstream as
> https://www.mail-archive.com/xen-devel@lists.xen.org/msg105232.html

I did submit it upstream and it looks like it will be accepted into
4.9 which means we can remove this in the future.

>
>  With that,
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

Thanks!

Alistair

>
>
>  Regards,
>  Arnout
>
>>
>>  Regardless of this: thanks for the contribution, Alistair!
>>
>>  Regards,
>>  Arnout
>>
>
> --
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF