[Buildroot] [PATCH 2/7] package configs: clean up ordering.

Adam Duskett aduskett at gmail.com
Sat Apr 22 17:23:00 UTC 2017


Hey, sorry about sending everything at once, I usually do a test-run to a
separate account of mine to make sure all the formatting looks good, and I
forgot to remove the buildroot email address out of it.

Totally my fault!

On Sat, Apr 22, 2017 at 9:56 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Fri, 21 Apr 2017 11:24:47 -0400, Adam Duskett wrote:
>> The check-package script when ran gives warnings on ordering issues
>> on all of these Config files.  This patch cleans up all warnings
>> related to the ordering in the Config files in the package directory.
>>
>> The appropriate ordering is: type, default, depends on, select, help
>> See http://nightly.buildroot.org/#_config_files for more information.
>>
>> Signed-off-by: Adam Duskett <aduskett at codeblue.com>
>
> This is really too long/too boring to review. I believe this should
> rather be done progressively, or split into smaller patches. One patch
> per package is quite certainly too much. Maybe one patch for packages
> starting with "a", one for packages starting with "b", etc.
>
> But don't send the whole thing at once. We don't want to have the
> patchwork backlog flooded by cleanup patches.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com



More information about the buildroot mailing list