[Buildroot] [PATCH v5 08/34] package/kodi: bump to version 17.1-Krypton
Yann E. MORIN
yann.morin.1998 at free.fr
Sat Apr 22 20:54:21 UTC 2017
Bernd, All,
On 2017-04-22 22:40 +0200, Bernd Kuhls spake thusly:
> Am Sat, 22 Apr 2017 22:24:57 +0200 schrieb Yann E. MORIN:
> >> package/kodi/0002-cmake-add-FindIconv.cmake.patch | 171 +++
> > That patch to find iconv is a feature patch (add support for building
> > under uClibc). We avoid having feature patches. At best make it a
> > separate changeset.
> building Kodi 16 with uClibc is already possible, so imho it is not a
> feature patch, instead it fixes the problem mentioned in the patch
> description.
Maybe Kodi 16 does build with uClibc, but not Kodi 17; it is not
supported upstream, and your patch has not yet been accepted.
Now, that you call that a regression in Kodi, sure. But from our point
of view (Buildroot), what you provide is a feature patch.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list