[Buildroot] [PATCH 28/29] package/qt: drop option for license approved

Arnout Vandecappelle arnout at mind.be
Sun Apr 23 20:59:58 UTC 2017



On 23-04-17 22:31, Yann E. MORIN wrote:
> As stated in previous commits, Buildroot only ever uses the free
> license, and we do not have a click-wrap approval for any such free
> license for any other package.
> 
> The option to approve the license now has no prompt and is no longer
> used anywhere. Drop it and make it a legacy entry.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Julien Corjon <corjon.j at ecagroup.com>
> Cc: Peter Seiderer <ps.report at gmx.net>
> ---
>  Config.in.legacy     | 6 ++++++
>  package/qt/Config.in | 4 ----
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 8e9f3d175d..52cda9808e 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -145,6 +145,12 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2017.05"
>  
> +config BR2_PACKAGE_QT_LICENSE_APPROVED
> +	bool "Qt free license now always approved"
> +	select BR2_LEGACY
> +	help
> +	  Use of Qt in Buildroot now always use the free license of Qt.

 IMO this doesn't bring any value. If the user already has selected to approve
the free license, nothing really changes for them so there's no point drawing
their attention to legacy.

 We should instead give a legacy warning when the user *didn't* have the option
selected. But that's not possible, of course.

 Therefore, I'd say we drop the legacy handling for this option.


 Regards,
 Arnout
> +
>  config BR2_PACKAGE_PORTMAP
>  	bool "portmap has been removed"
>  	select BR2_LEGACY
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 5f07bd22f9..d3a01da87f 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -99,10 +99,6 @@ config BR2_PACKAGE_QT_STATIC
>  
>  endchoice
>  
> -config BR2_PACKAGE_QT_LICENSE_APPROVED
> -	bool
> -	default y
> -
>  config BR2_PACKAGE_QT_CONFIG_FILE
>  	string "Config file"
>  	help
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list