[Buildroot] [PATCH v10 1/2] genimage.sh: fix calling from BR2_ROOTFS_POST_IMAGE_SCRIPT

Peter Korsgaard peter at korsgaard.com
Thu Apr 27 21:36:01 UTC 2017


>>>>> "Abhimanyu" == Abhimanyu Vishwakarma <abhimanyu.v at gmail.com> writes:

 > From: Abhimanyu Vishwakarma <Abhimanyu.V at gmail.com>
 > When called from BR2_ROOTFS_POST_IMAGE_SCRIPT, this script
 > ends up with following error:

 > Error: Missing argument

 > This is because, an extra positional argument is also passed
 > along with BR2_ROOTFS_POST_SCRIPT_ARGS. genimage.sh didn't
 > have support to parse positional and optional arguments
 > together.

 > Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.V at gmail.com>
 > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
 > Tested-by: Rahul Bedarkar <rahulbedarkar89 at gmail.com>

 > ---
 >  Changes v7->v8
 >    - New file
 >  Changes v8->v9
 >    - Fix indentation
 >    - Use bash basename as script name instead hardcoding (by arnout)
 >  Changes v9->v10 (Suggested by Arnout)
 >    - Remove tab indentation (use existing 2 space indent)
 >    - Fix commit message grammer
 >    - add reviewed-by tag
 >    - keep tested-by tag as no code change just indentation

 >  support/scripts/genimage.sh | 19 ++++++++++++++-----
 >  1 file changed, 14 insertions(+), 5 deletions(-)

Committed, thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list