[Buildroot] [PATCH 1/1] package/snappy: remove pthread handling for static builds

Yann E. MORIN yann.morin.1998 at free.fr
Sun Aug 6 17:17:28 UTC 2017


Bernd, All,

On 2017-08-04 06:02 +0200, Bernd Kuhls spake thusly:
> As pointed out by Thomas[1] the special handling of libpthread for
> static builds is not needed anymore.

What is iomportant to state is why it is no longer needed.

Previously, the unit-tests were always built, and that's what caused the
linking errors.

But now, we explicitly no longer build the unit-tests, so we no longer
need to workar9ond the static build limitation anymore.

However, it is to be noted that packages that link against a static
snappy will still need to add -pthreads to their linker flags (if they
don't already do tht for themselves, that is).

Otherwise:

Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

Regards,
Yann E. MORIN.

> Tested with the following musl & uclibc defconfigs which also fix build
> errors:
> http://autobuild.buildroot.net/results/39f/39f9fc4300ddca19e8a533765b46838003752000/
> http://autobuild.buildroot.net/results/886/8860b9259f7a3aecb2ddbfa787be048072bd347b/
> 
> [1] http://lists.busybox.net/pipermail/buildroot/2017-July/199549.html
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> ---
>  package/snappy/snappy.mk | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/package/snappy/snappy.mk b/package/snappy/snappy.mk
> index f5df6bf1f..a537ade57 100644
> --- a/package/snappy/snappy.mk
> +++ b/package/snappy/snappy.mk
> @@ -11,13 +11,4 @@ SNAPPY_LICENSE_FILES = COPYING
>  SNAPPY_INSTALL_STAGING = YES
>  SNAPPY_CONF_OPTS = -DSNAPPY_BUILD_TESTS=OFF
>  
> -# libsnappy links with libstdc++. Some libstdc++/arch variants use
> -# pthread symbols for internal locking if built with thread
> -# support. libstdc++ does not have a .pc file, and its .la file does
> -# not mention -pthread.  So, static linkig to libstdc++ will fail if
> -# -pthread is not explicity linked to. Only do that for static builds.
> -ifeq ($(BR2_STATIC_LIBS)$(BR2_TOOLCHAIN_HAS_THREADS),yy)
> -SNAPPY_CONF_OPTS += LIBS=-pthread
> -endif
> -
>  $(eval $(cmake-package))
> -- 
> 2.11.0
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list