[Buildroot] [PATCH 2/2] package/mono: bump to version 5.0.1.1
Angelo Compagnucci
angelo.compagnucci at gmail.com
Fri Aug 11 10:57:12 UTC 2017
Dear Arnout Vandecappelle,
2017-08-11 12:00 GMT+02:00 Arnout Vandecappelle <arnout at mind.be>:
>
>
> On 11-08-17 10:14, Angelo Compagnucci wrote:
>> This patch bumps to mono 5.0.1.1 and updates the unit tests patch
>> accordingly.
>>
>> Signed-off-by: Angelo Compagnucci <angelo.compagnucci at gmail.com>
>> ---
>> .../0006-Remove-unit-tests-from-mono-compilation.patch | 14 +++++++-------
>
> What is the upstream status of all the patches? Most of the other patches look
> like they could be applicable for upstream, can you send them?
All upstremeable patches are already be sent. Mono has a really long
release cycle and the patches, also if applied, are not released in
stable branches immediately.
> Also, patch 4 says:
>
> Patch is upstream:
>
> https://github.com/mono/mono/commit/40c171799b671718969ee28a02f92884d7fd181e
>
> so why is this one not removed? Could you mention that explicitly in the commit log?
Cause the patch is present from the tag mono-5.4.0.135 (future
release) the stable release is now at 5.0.1.1 .
I usually do care to remove patches upstreamed.
> It would also be nice to rewrite patch 6 and 8 so they are upstreamable, but I
> can imagine that that's more complicated.
Patch 8 is not upstremeable cause the way buildroot handles paths.
Buildroot sets $(mono_libdir) to the full host path, instead mono here
expects something related to the / of the target.
For patch 6 I've not tried cause it's a bit of a corner case: running
mono unit-tests during compilation is not advisable cause it takes
time but also cause they expects a certain environment that buildroot
screws up. To make the unit-tests running in buildroot mono should be
patched, but I originally though it was not necessary.
>
> Regards,
> Arnout
>
>
> [snip]
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
Profile: http://it.linkedin.com/in/compagnucciangelo
More information about the buildroot
mailing list