[Buildroot] [PATCH] package/qt5base: libgtk3 support depends on X11 backend

Arnout Vandecappelle arnout at mind.be
Fri Aug 11 12:07:31 UTC 2017



On 10-08-17 23:17, Peter Seiderer wrote:
> Hello Arnout,
> 
> On Wed, 9 Aug 2017 23:53:52 +0200, Arnout Vandecappelle <arnout at mind.be> wrote:
> 
>>  Hi Peter,
>>
>> On 09-08-17 09:38, Peter Seiderer wrote:
>>> Hello Joshua,
>>>
>>>> Gesendet: Mittwoch, 09. August 2017 um 02:09 Uhr
>>>> Von: "Joshua Henderson" <joshua.henderson at microchip.com>
>>>> An: buildroot at buildroot.org
>>>> Cc: "Peter Seiderer" <ps.report at gmx.net>, "Julien Corjon" <corjon.j at ecagroup.com>, "Brent Sink" <brents_3 at hotmail.com>, "Naoki Matsumoto" <n-matsumoto at melcoinc.co.jp>
>>>> Betreff: [PATCH] package/qt5base: libgtk3 support depends on X11 backend
>>>>
>>>> libgtk3 can conditionally be build with or without the X11 backend unlike
>>>> libgtk2. If libgtk3 is enabled and the X11 backend is not enabled for
>>>> BR2_PACKAGE_QT5_VERSION_LATEST, a build error [1] is introduced.  This change
>>>> disables gtk support in this case.
>>> NAK - or only as a workaround, the real issue is a missing QT_EGL_NO_X11/MESA_EGL_NO_X11_HEADERS
>>> define, see e.g. [2] for further discussion...
>>
>>  Do you expect a proper resolution to arrive before 2017.08, or should I apply
>> Joshua's patch (with modified commit message) to master after all?
> 
> Would prefer to try patch [3] or add MESA_EGL_NO_X11_HEADERS define via
> arch.conf (as done e.g. for libatomic by Yann's patch [4])...but will
> not find enough time the next two weeks to try...

 Also your reference [3] got negative review, and doing it through arch.conf
sounds like a hack. So I've applied to master, with a few changes:
    - extend commit message
    - improve comment
    - also pass -no-gtk if libgtk3 is not selected

 Regards,
 Arnout

> 
> Regards,
> Peter
> 
> [3] https://codereview.qt-project.org/#/c/198906/
> [4] https://git.buildroot.net/buildroot/commit/?id=7d286be4f96cfb731e184c3e8cfea27a031bde3c
> 
>>
>>  Regards,
>>  Arnout
>>
>>>
>>> Regards,
>>> Peter
>>>
>>> [2] http://lists.busybox.net/pipermail/buildroot/2017-July/196075.html
>>>
>>
> 
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list