[Buildroot] [PATCH 1/2] package/monolite: bump to version 1050001000

Arnout Vandecappelle arnout at mind.be
Fri Aug 11 20:35:19 UTC 2017



On 11-08-17 17:07, Angelo Compagnucci wrote:
> Dear Arnout Vandecappelle ,
> 
> 2017-08-11 15:38 GMT+02:00 Arnout Vandecappelle <arnout at mind.be>:
>>
>>
>> On 11-08-17 12:40, Angelo Compagnucci wrote:
>>> Dear Arnout Vandecappelle,
>>>
>>> 2017-08-11 11:56 GMT+02:00 Arnout Vandecappelle <arnout at mind.be>:
>>>>
>>>>
>>>> On 11-08-17 10:14, Angelo Compagnucci wrote:
>>>>> The latest version of mono carries a bit of changes in the monolite
>>>>> package: the version string changes and from now on, monolite should
>>>>> be installed in a subdirectory with the exact version string as a name.
>>>>
>>>>  And does this work independently of the version bump of mono itself? I.e., if
>>>> we apply just this patch, will mono still build?
>>>
>>> Nope. The patches are sent in a series for the purpose to be both applied.
>>>
>>>>  If not, then the two patches should be squashed. If you don't have time we can
>>>> do that while applying.
>>>
>>> Sorry for the noise, but this is not how the things worked in the
>>> past. I was suggested several times in the past to send a patch for
>>> each modification/package.
>>
>>  Yes, but only if they indeed work separately. Don't worry, I'll squash while
>> applying.
> 
> I searched the history for the mono package just to be sure and such a
> way of squashing commits for separate packages was never been done.
> I'm a bit puzzled ...
> 
> Right now I'm working updating sysdig and it requires som bumps to
> other packages, should I send a squashed patch?!

 Usually it should be one patch per package. But in this case, the bump of
monolite as such would break mono. I assume that normally that's not the case,
i.e. monolite 156 can still be used for building mono 4.6.2.16. So normally they
don't have to be updated together. It's only now that they have to be squashed.

 Now, it's not really *that* important. It's only important for being able to
trace back when something broke, and that's not needed very often. But since I
saw this potential issue and could easily "fix" it, I did.

 If in doubt, make separate patches. Squashing after the fact is easy, splitting
is not.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list