[Buildroot] Analysis of build results for 2017-08-14
Matthew Weber
matthew.weber at rockwellcollins.com
Thu Aug 17 12:01:38 UTC 2017
Thomas,
On Thu, Aug 17, 2017 at 2:09 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Wed, 16 Aug 2017 21:00:26 -0500, Matthew Weber wrote:
>
>> > I think it's best to put the empty _SITE check in an
>> > ifneq ($(BR2_PRIMARY_SITE_ONLY),y)
>>
>> https://patchwork.ozlabs.org/patch/802290/
>
> I know this is what Arnout suggested, but I'm not sure it's my
> preferred fix. Indeed, what about instead dropping the:
>
> if !BR2_PRIMARY_SITE_ONLY
> ...
> endif
>
> condition in Config.in that encloses the definition of BR2_GNU_MIRROR,
> BR2_LUAROCKS_MIRROR, etc. ?
>
> Even though I agree such variables are not used when
> BR2_PRIMARY_SITE_ONLY=y, I don't see why we hide them. Removing this
> condition in Config.in avoids the need for adding another condition in
> pkg-generic.mk, and it seems more logical to me.
>
So still keep the condition around BR2_BACKUP_SITE, right? (remove
from around the rest(LUA/CPAN/GNU/KERNEL))
Matt
More information about the buildroot
mailing list