[Buildroot] Analysis of build results for 2017-08-14

[Arnout Vandecappelle]

On 17-08-17 14:01, Matthew Weber wrote:
> Thomas,
> 
> On Thu, Aug 17, 2017 at 2:09 AM, Thomas Petazzoni
> <thomas.petazzoni at free-electrons.com> wrote:
>> Hello,
>>
>> On Wed, 16 Aug 2017 21:00:26 -0500, Matthew Weber wrote:
>>
>>>>  I think it's best to put the empty _SITE check in an
>>>> ifneq ($(BR2_PRIMARY_SITE_ONLY),y)
>>>
>>> https://patchwork.ozlabs.org/patch/802290/
>>
>> I know this is what Arnout suggested, but I'm not sure it's my
>> preferred fix. Indeed, what about instead dropping the:
>>
>> if !BR2_PRIMARY_SITE_ONLY
>> ...
>> endif
>>
>> condition in Config.in that encloses the definition of BR2_GNU_MIRROR,
>> BR2_LUAROCKS_MIRROR, etc. ?
>>
>> Even though I agree such variables are not used when
>> BR2_PRIMARY_SITE_ONLY=y, I don't see why we hide them. Removing this
>> condition in Config.in avoids the need for adding another condition in
>> pkg-generic.mk, and it seems more logical to me.
>>
> 
> So still keep the condition around BR2_BACKUP_SITE, right?  (remove
> from around the rest(LUA/CPAN/GNU/KERNEL))

 Also remove it from backup site, I think. That way, you can toggle the
PRIMARY_ONLY condition without loosing the rest of your _SITE configurations. I
think that that's why Thomas calls it more logical. The purpose of PRIMARY_ONLY
is to be able to toggle it, cfr. the commit log that added it:

commit 5a83e0849964c5160b980bb57ce89e28684a7dbb
Author: Thomas De Schampheleire <patrickdepinguin+buildroot at gmail.com>
Date:   Fri Jun 22 07:37:03 2012

    Package downloads: allow restricting to primary site only

    This patch adds a new config option BR2_PRIMARY_SITE_ONLY that, when set,
    restricts package downloads to the specified BR2_PRIMARY_SITE. If the package
    is not present on the primary site, the download fails.

    This is useful for project developers who want to ensure that the project can
    be built even if the upstream tarball locations disappear.

    [thomas.petazzoni at free-electrons.com:
     Extend config option help message with more details coming from the
     commit log. Added a dependency on the fact that a primary site has
     been defined. Without any primary site (the default configuration),
     this new option does not make any sense.]

    Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
    Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>



 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF