[Buildroot] [PATCH] support/scripts: add script to test a package

Peter Korsgaard peter at korsgaard.com
Tue Feb 7 14:41:27 UTC 2017


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > Luca, All,
 > On 2017-02-06 21:40 +0100, Luca Ceresoli spake thusly:
 >> On 06/02/2017 19:02, Yann E. MORIN wrote:
 > [--SNIP--]
 >> > +    printf ", olddefconfig"
 >> > +    if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
 >> > +        printf ": FAILED\n"
 >> > +        return
 >> > +    fi
 >> > +    while read line; do
 >> > +        if ! grep "^${line}\$" "${dir}/.config" >/dev/null 2>&1; then
 >> 
 >> I suggest removing the redirects and using 'grep -q' here.

 > grep -q is not POSIX. ;-)

But is that a real concern? We do use grep -q quite a bit already
(including in dependencies.sh):

git grep 'grep -q' | wc -l
46

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list