[Buildroot] [PATCH 1/6] support/scripts: add script to test a package

[Thomas Petazzoni]

Hello,

For some reason only your cover letter had PATCHv3, not the patches
themselves. Could you check what happened?

On Wed,  8 Feb 2017 21:15:24 +0100, Yann E. MORIN wrote:
> This script helps in testing that a package builds fine on a wide range
> of architectures and toolchains: BE/LE, 32/64-bit, musl/glibc/uclibc...
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> [yann.morin.1998 at free.fr:
>  - completely rewrite the script from Thomas, with help from Luca
> ]
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Luca Ceresoli <luca at lucaceresoli.net>
> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> Acked-by: Luca Ceresoli <luca at lucaceresoli.net>
> Reviewed-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>

First of all, thanks for taking over my initial crappy submission and
making it something production ready. I've applied your patch, but I
nonetheless have a few comments about it. See below.

> +    opts="$( getopt -n "${my_name}" -o "${o}" -l "${O}" -- "${@}"  )"

I continue to terribly dislike this whole concept of putting a space
after an opening parenthesis and before a closing parenthesis.

I know this is your coding style, but it is *not* the Buildroot coding
style. So I'd appreciate if the shell scripts could also comply with
the Buildroot coding style on this.

> +    printf "download config"

I find all these prints to be really useless, and they clutter the
output for nothing. My original script had a very lean and readable
output:

	<toolchain>:	<status>

and now it's the much more verbose (and useless):

                armv5-ctng-linux-gnueabi: download config, olddefconfig, build: OK
              armv7-ctng-linux-gnueabihf: download config, olddefconfig, build: OK

(which would get even more verbose if I had passed a -p option, since
dirclean would have been added).

I'd really prefer if we got rid of those additional prints, they are
not useful, and make the whole thing less readable.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com