[Buildroot] [PATCH 5/6] support/test-pkg: add option to use an alternate list of toolchains

[Thomas De Schampheleire]

On Wed, Feb 8, 2017 at 9:15 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> For now, testing a package requires network access. However, there are
> situations where everything is already cached locally (especially the
> toolchains tarballs) and network is not available (e.g. in the train,
> travelling back from FOSDEM...)
>
> Alternatively, one may also want to test against a subset of the default
> toolchains (e.g. the ones known to have a specific issue).
>
> Add an option to use an alternate URL, which can be remote or a path to
> a local file.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> ---
>  support/scripts/test-pkg | 47 +++++++++++++++++++++++++++++++++++++++++------
>  1 file changed, 41 insertions(+), 6 deletions(-)
>
> diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
> index 59c9f23..e77c804 100755
> --- a/support/scripts/test-pkg
> +++ b/support/scripts/test-pkg
> @@ -5,16 +5,17 @@ TOOLCHAINS_URL='http://autobuild.buildroot.org/toolchains/configs/toolchain-conf
>
>  main() {
>      local o O opts
> -    local cfg dir pkg random toolchain
> +    local cfg dir pkg random url toolchain
>      local ret nb_dl nb_cfg nb_skip nb_clean nb_build
>      local -a toolchains
>
> -    o='hc:d:p:r:'
> -    O='help,config-snippet:build-dir:package:,random:'
> +    o='hc:d:p:r:t:'
> +    O='help,config-snippet:build-dir:package:,random:,toolchains:'
>      opts="$( getopt -n "${my_name}" -o "${o}" -l "${O}" -- "${@}"  )"
>      eval set -- "${opts}"
>
>      random=0
> +    url="${TOOLCHAINS_URL}"
>      while [ ${#} -gt 0 ]; do
>          case "${1}" in
>          (-h|--help)
> @@ -32,6 +33,9 @@ main() {
>          (-r|--random)
>              random="${2}"; shift 2
>              ;;
> +        (-t|--toolchains)
> +            url="${2}"; shift 2
> +            ;;
>          (--)
>              shift; break
>              ;;
> @@ -44,10 +48,16 @@ main() {
>          dir="${HOME}/br-test-pkg"
>      fi
>
> +    # Transform local paths to URI to make curl happy and simplify
> +    # our code path
> +    case "${url}" in
> +    (/*)    url="file://${url}";;
> +    esac
> +
>      # Extract the URLs of the toolchains; drop internal toolchains
>      # E.g.: http://server/path/to/name.config,arch,libc
>      #  -->  http://server/path/to/name.config
> -    toolchains=( $( curl -s "${TOOLCHAINS_URL}" \
> +    toolchains=( $( curl -s "${url}" \
>                      |sed -r -e 's/,.*//; /internal/d;' \
>                      |if [ ${random} -gt 0 ]; then \
>                          sort -R |head -n ${random}
> @@ -102,6 +112,12 @@ build_one() {
>      local pkg="${4}"
>      local toolchain line skip
>
> +    # Transform local paths to URI to make curl happy and simplify
> +    # our code path
> +    case "${url}" in
> +    (/*)    url="file://${url}";;
> +    esac

Some duplication that could be extracted to a function?