[Buildroot] [PATCH 1/1] Install raptor package in staging

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Feb 13 14:58:29 UTC 2017


Hello,

Thanks for your contribution! This looks mostly good, but I have a few
comments below.

The commit title should be:

	raptor: install package to staging

indeed, for consistency reasons, we want all commit titles to follow
the format:

	<package>: <short description>

On Mon, 13 Feb 2017 08:01:13 +0000 (UTC), Erwan Gautron wrote:
> Signed-off-by: Erwan Gautron <erwan.gautron at yahoo.fr>

Could you expand the commit log to explain *why* we want to install
this package to staging?

>  package/raptor/raptor.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/raptor/raptor.mk b/package/raptor/raptor.mk
> index aea14e3..a2c2b23 100644
> --- a/package/raptor/raptor.mk
> +++ b/package/raptor/raptor.mk
> @@ -13,7 +13,7 @@ RAPTOR_LICENSE_FILES = LICENSE.txt
>  
>  # Flag is added to make sure the patch is applied for the configure.ac of raptor.
>  RAPTOR_AUTORECONF = YES
> -
> +RAPTOR_INSTALL_STAGING=YES

Missing spaces before and after the equal sign.

I could have fixed this and the commit title myself, but I can't fix
the reason why this patch is useful. So can you fix all three issues
and submit an updated version of your patch?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list