[Buildroot] [PATCH 1/1] Install raptor package in staging

Erwan Gautron erwan.gautron at yahoo.fr
Tue Feb 14 10:31:06 UTC 2017


HelloI'll do 
BR
Erwan


      De : Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
 À : Erwan Gautron <erwan.gautron at yahoo.fr> 
Cc : "buildroot at buildroot.org" <buildroot at buildroot.org>
 Envoyé le : Lundi 13 février 2017 15h58
 Objet : Re: [Buildroot] [PATCH 1/1] Install raptor package in staging
   
Hello,

Thanks for your contribution! This looks mostly good, but I have a few
comments below.

The commit title should be:

    raptor: install package to staging

indeed, for consistency reasons, we want all commit titles to follow
the format:

    <package>: <short description>

On Mon, 13 Feb 2017 08:01:13 +0000 (UTC), Erwan Gautron wrote:
> Signed-off-by: Erwan Gautron <erwan.gautron at yahoo.fr>

Could you expand the commit log to explain *why* we want to install
this package to staging?

>  package/raptor/raptor.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/raptor/raptor.mk b/package/raptor/raptor.mk
> index aea14e3..a2c2b23 100644
> --- a/package/raptor/raptor.mk
> +++ b/package/raptor/raptor.mk
> @@ -13,7 +13,7 @@ RAPTOR_LICENSE_FILES = LICENSE.txt
>  
>  # Flag is added to make sure the patch is applied for the configure.ac of raptor.
>  RAPTOR_AUTORECONF = YES
> -
> +RAPTOR_INSTALL_STAGING=YES

Missing spaces before and after the equal sign.

I could have fixed this and the commit title myself, but I can't fix
the reason why this patch is useful. So can you fix all three issues
and submit an updated version of your patch?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170214/f883c632/attachment-0002.html>


More information about the buildroot mailing list