[Buildroot] [PATCH v2 1/3] package/sdl2: enable opengl support

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Feb 26 13:57:32 UTC 2017


Hello,

On Sat, 25 Feb 2017 14:35:58 +0100, Romain Naour wrote:

> +config BR2_PACKAGE_SDL2_OPENGL
> +	bool "OpenGL (GLX)"
> +	depends on BR2_PACKAGE_HAS_LIBGL
> +	depends on BR2_PACKAGE_XORG7

Are you sure this doesn't need BR2_PACKAGE_SDL2_X11 ? I.e what happens
if you build SDL2 with BR2_PACKAGE_SDL2_OPENGL=y but
BR2_PACKAGE_SDL2_X11 disabled ?

> +ifeq ($(BR2_PACKAGE_SDL2_OPENGL),y)
> +SDL2_CONF_OPTS += --enable-video-opengl
> +SDL2_DEPENDENCIES += libgl

Also, is libgl sufficient here? What happens if you select
nvidia-driver as the OpenGL provider for example? It doesn't depend on
any X.org package, so are you sure by the time SDL2 runs its configure
script, enough things have been built?

Can you verify by enabling nvidia-driver, and then running "make sdl2" ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list