[Buildroot] [PATCH v2 1/3] package/sdl2: enable opengl support

Romain Naour romain.naour at gmail.com
Sun Feb 26 15:32:40 UTC 2017


Hi Thomas, All,

Le 26/02/2017 à 14:57, Thomas Petazzoni a écrit :
> Hello,
> 
> On Sat, 25 Feb 2017 14:35:58 +0100, Romain Naour wrote:
> 
>> +config BR2_PACKAGE_SDL2_OPENGL
>> +	bool "OpenGL (GLX)"
>> +	depends on BR2_PACKAGE_HAS_LIBGL
>> +	depends on BR2_PACKAGE_XORG7
> 
> Are you sure this doesn't need BR2_PACKAGE_SDL2_X11 ? I.e what happens
> if you build SDL2 with BR2_PACKAGE_SDL2_OPENGL=y but
> BR2_PACKAGE_SDL2_X11 disabled ?

OpenGL (GLX) option only check for the following headers:
#include <GL/gl.h>
#include <GL/glx.h>

So, SDL2 build fine even without BR2_PACKAGE_SDL2_X11.
However you're probably right since GLX mean OpenGL with X11 support and
selecting BR2_PACKAGE_SDL2_X11 allow to enable additional X11 libraries support.
I'll add a select BR2_PACKAGE_SDL2_X11 since it was enabled for my runtime test.

> 
>> +ifeq ($(BR2_PACKAGE_SDL2_OPENGL),y)
>> +SDL2_CONF_OPTS += --enable-video-opengl
>> +SDL2_DEPENDENCIES += libgl
> 
> Also, is libgl sufficient here? What happens if you select
> nvidia-driver as the OpenGL provider for example? It doesn't depend on
> any X.org package, so are you sure by the time SDL2 runs its configure
> script, enough things have been built?

nvidia-driver is an libgl provider only if BR2_PACKAGE_NVIDIA_DRIVER_XORG=y,
so the libgl provider select a minimal set of X11 libraries that are already
build when sdl2 build start.
This is also the case when mesa3d is used as libgl provider.

> 
> Can you verify by enabling nvidia-driver, and then running "make sdl2" ?

I tried with this deconfig fragment a sdl2 build fine.

BR2_PACKAGE_SDL2=y
BR2_PACKAGE_SDL2_OPENGL=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XSERVER_XORG_SERVER=y
BR2_PACKAGE_NVIDIA_DRIVER=y

Best regards,
Romain

> 
> Thanks,
> 
> Thomas
> 




More information about the buildroot mailing list