[Buildroot] [PATCH] libmad: disable ASO support for thumb-only ARM cores

Baruch Siach baruch at tkos.co.il
Sun Jan 8 04:37:13 UTC 2017


Hi Peter,

On Sun, Jan 08, 2017 at 12:11:26AM +0100, Peter Korsgaard wrote:
> Fixes:
> http://autobuild.buildroot.net/results/8d4/8d4ea8613487297f2c33f3b9cbd8903cfb96e4c6/
> 
> The ARM specific optimizations enabled by LIBMAD_ASO needs classic ARM
> instructions support, so disable for thumb-only cores.
> 
> Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
> ---
>  package/libmad/Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libmad/Config.in b/package/libmad/Config.in
> index 7d66976c1..2f7543f74 100644
> --- a/package/libmad/Config.in
> +++ b/package/libmad/Config.in
> @@ -37,7 +37,8 @@ config BR2_PACKAGE_LIBMAD_SSO
>  
>  config BR2_PACKAGE_LIBMAD_ASO
>  	bool "Architecture-specific optimizations"
> -	default y

Why is this change needed? Isn't the added dependency enough?

> +	# arm optimization needs classic arm instructions support
> +	depends on !(BR2_arm && !BR2_ARM_CPU_HAS_ARM)
>  	help
>  	  Use certain architecture-specific optimizations.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -



More information about the buildroot mailing list