[Buildroot] [PATCH v2 1/3] python-protobuf: Allow host building

[Arnout Vandecappelle]

On 15-01-17 22:30, Yann E. MORIN wrote:
> William, All,
> 
> On 2017-01-12 11:15 -0800, William A. Kennington III spake thusly:
>> Currently python-protobuf does not allow be built as a host package
>> during a cross compile. We would like to be able to build nanopb as a
>> host package but can't without host-python-protobuf.
>>
>> Signed-off-by: William A. Kennington III <wak at google.com>
>> ---
>>  package/python-protobuf/python-protobuf.mk | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/python-protobuf/python-protobuf.mk b/package/python-protobuf/python-protobuf.mk
>> index d8be76dd7..d46bda243 100644
>> --- a/package/python-protobuf/python-protobuf.mk
>> +++ b/package/python-protobuf/python-protobuf.mk
>> @@ -13,4 +13,5 @@ PYTHON_PROTOBUF_DEPENDENCIES = host-protobuf
>>  PYTHON_PROTOBUF_SETUP_TYPE = setuptools
>>  PYTHON_PROTOBUF_SUBDIR = python
>>  
>> +$(eval $(host-python-package))
>>  $(eval $(python-package))
> 
> This is not documented (AFAIK), but the host variant must go after the
> target variant. Otherwise, strange things can happen (because of the way
> variables have default values that depend on the order of evaluation,
> like the source archive for example).

 I think that this is not true. If it were true, then it would mean that
host-only packages would be problematic, no? In fact, it is the
host-after-target order where strange things could happen, but package-generic
obviously deals with those strange things :-).


 That said, the Buildroot convention is to have host after target, so William,
please do it like that.

 Regards,
 Arnout

> Note: this is valid for the following patch as awell, of course.
> 
> Regards,
> Yann E. MORIN.
> 
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF