[Buildroot] [PATCH] gqrx: new package

[Romain Naour]

Hi Gwenhael,

Le 08/01/2017 à 23:15, Gwenhael Goavec-Merou a écrit :
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
> 
> Gqrx is an open source software defined radio (SDR) receiver implemented
> using GNU Radio and the Qt GUI toolkit. Currently it works on Linux
> and Mac with hardware supported by gr-osmosdr, including Funcube Dongle,
> RTL-SDR, Airspy, HackRF, BladeRF, RFSpace, USRP and SoapySDR.
> 
> Gqrx can operate as an AM/FM/SSB receiver with audio output or as an
> FFT-only instrument. There are also various hooks for interacting
> with external application using network sockets.

gqrx doesn't build with gcc6 due to Wmisleading-indentation

output/build/gqrx-v2.6/src/qtgui/plotter.cpp: In member function ‘void
CPlotter::drawOverlay()’:
output/build/gqrx-v2.6/src/qtgui/plotter.cpp:1338:13: warning: this ‘for’ clause
does not guard... [-Wmisleading-indentation]
             for (; level < nLevels && tagEnd[level] > x; level++);
             ^~~
output/build/gqrx-v2.6/src/qtgui/plotter.cpp:1339:17: note: ...this statement,
but the latter is misleadingly indented as if it is guarded by the ‘for’
                 level %= nLevels;

> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
> ---
>  package/Config.in      |  1 +
>  package/gqrx/Config.in | 38 ++++++++++++++++++++++++++++++++++++++
>  package/gqrx/gqrx.hash |  2 ++
>  package/gqrx/gqrx.mk   | 15 +++++++++++++++
>  4 files changed, 56 insertions(+)
>  create mode 100644 package/gqrx/Config.in
>  create mode 100644 package/gqrx/gqrx.hash
>  create mode 100644 package/gqrx/gqrx.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 8c8c33e..a4341e5 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1429,6 +1429,7 @@ menu "Miscellaneous"
>  	source "package/empty/Config.in"
>  	source "package/gnuradio/Config.in"
>  	source "package/googlefontdirectory/Config.in"
> +	source "package/gqrx/Config.in"
>  	source "package/gr-osmosdr/Config.in"
>  	source "package/gsettings-desktop-schemas/Config.in"
>  	source "package/haveged/Config.in"
> diff --git a/package/gqrx/Config.in b/package/gqrx/Config.in
> new file mode 100644
> index 0000000..807b040
> --- /dev/null
> +++ b/package/gqrx/Config.in
> @@ -0,0 +1,38 @@
> +comment "gqrx needs a toolchain w/ C++, threads, wchar, dynamic library"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
> +		!BR2_USE_WCHAR || BR2_STATIC_LIBS
> +
> +comment "gqrx needs gnuradio, fftw's single precision"
> +	depends on !BR2_PACKAGE_GNURADIO || !BR2_PACKAGE_FFTW_PRECISION_SINGLE)
> +
> +config BR2_PACKAGE_GQRX
> +	bool "gqrx"
> +	depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE # gnuradio
> +	depends on BR2_PACKAGE_GNURADIO
> +	depends on BR2_INSTALL_LIBSTDCPP # boost, qt5
> +	depends on !BR2_STATIC_LIBS # qt5
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # boost, qt5
> +	depends on BR2_USE_WCHAR # boost, qt5
> +	select BR2_PACKAGE_BOOST
> +	select BR2_PACKAGE_BOOST_PROGRAM_OPTIONS
> +	select BR2_PACKAGE_BOOST_SYSTEM
> +	select BR2_PACKAGE_GNURADIO_ANALOG
> +	select BR2_PACKAGE_GNURADIO_AUDIO

Missing dependencies on BR2_PACKAGE_ALSA_LIB || BR2_PACKAGE_PORTAUDIO:

warning: (BR2_PACKAGE_GQRX) selects BR2_PACKAGE_GNURADIO_AUDIO which has unmet
direct dependencies (BR2_PACKAGE_GNURADIO && (BR2_PACKAGE_ALSA_LIB ||
BR2_PACKAGE_PORTAUDIO))

I guess you want BR2_PACKAGE_ALSA_LIB since only the Gr-audio backend is used.

> +	select BR2_PACKAGE_GNURADIO_BLOCKS
> +	select BR2_PACKAGE_GNURADIO_DIGITAL
> +	select BR2_PACKAGE_GNURADIO_FFT
> +	select BR2_PACKAGE_GNURADIO_FILTER
> +	select BR2_PACKAGE_GR_OSMOSDR
> +	select BR2_PACKAGE_QT5
> +	select BR2_PACKAGE_QT5BASE_GUI
> +	select BR2_PACKAGE_QT5BASE_WIDGETS
> +	select BR2_PACKAGE_QT5SVG
> +	help
> +	  Gqrx is an open source software defined radio (SDR) receiver implemented
> +	  using GNU Radio and the Qt GUI toolkit. Currently it works on Linux
> +	  and Mac with hardware supported by gr-osmosdr, including Funcube Dongle,
> +	  RTL-SDR, Airspy, HackRF, BladeRF, RFSpace, USRP and SoapySDR.
> +
> +	  Gqrx can operate as an AM/FM/SSB receiver with audio output or as an
> +	  FFT-only instrument. There are also various hooks for interacting
> +	  with external application using network sockets.

The help text is a bit too long:
http://nightly.buildroot.org/#writing-rules-config-in

Also add the upstream url.

Best regards,
Romain

> diff --git a/package/gqrx/gqrx.hash b/package/gqrx/gqrx.hash
> new file mode 100644
> index 0000000..2d126aa
> --- /dev/null
> +++ b/package/gqrx/gqrx.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated:
> +sha256 53d25db8d987a41ccccaf6fd85262bd7770cdfab5539b5901c4558756483c9db  gqrx-v2.6.tar.gz
> diff --git a/package/gqrx/gqrx.mk b/package/gqrx/gqrx.mk
> new file mode 100644
> index 0000000..b591e60
> --- /dev/null
> +++ b/package/gqrx/gqrx.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# gqrx
> +#
> +################################################################################
> +
> +GQRX_VERSION = v2.6
> +GQRX_SITE = $(call github,csete,gqrx,$(GQRX_VERSION))
> +GQRX_LICENSE = GPLv3+, Apache-2.0
> +GQRX_LICENSE_FILES = COPYING LICENSE-CTK
> +GQRX_DEPENDENCIES = boost gnuradio gr-osmosdr qt5base qt5svg
> +
> +GQRX_CONF_OPTS = -DLINUX_AUDIO_BACKEND=Gr-audio
> +
> +$(eval $(cmake-package))
>