[Buildroot] [PATCH 1/3] pkg-perl: add PREFER_INSTALLER variable

François Perrad francois.perrad at gadz.org
Tue Jan 24 09:46:49 UTC 2017


2017-01-22 7:34 GMT+01:00 Thomas Petazzoni
<thomas.petazzoni at free-electrons.com>:
> Hello,
>
> On Sat, 21 Jan 2017 12:51:16 +0100, Francois Perrad wrote:
>
>> +* +PERL_FOO_PREFER_INSTALLER+/+HOST_PERL_FOO_PREFER_INSTALLER+, with the
>> +  value 'EUMM', the use of +Makefile.PL+ is prefered at +Build.pl+.
>
> Should be "Build.PL" (i.e PL in capital letters).

Fixed in V2

>
>> +  By default, 'MB'.
>
> Is it possible to find values that are less cryptic than EUMM and MB ?
> Either a boolean style:

No, I use same name (prefer_installer) and values (EUMM, MB) as in
cpan client (see http://perldoc.perl.org/CPAN.html#Config-Variables).
I don't want invent new ones.

François

>
> <pkg>_USES_MODULE_BUILD = YES/NO
>
> or:
>
> <pkg>_BUILD_TYPE = Module-Build / ExtUtils-MakeMaker
>
> Or are EUMM/MB values already used in the Perl community?
>
>> +# equivalent at $CPAN::Config{prefer_installer}
>
> I don't understand what this sentence means.
>
>> +# legal values are MB and EUMM: if a module comes
>> +# with both a Makefile.PL and a Build.PL, use the
>> +# former (EUMM) or the latter (MB); if the module
>> +# comes with only one of the two, that one will be
>> +# used no matter the setting
>> +$(2)_PREFER_INSTALLER ?= MB
>
> If we keep this name, it should be:
>
> <pkg>_PREFERRED_INSTALLER
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot



More information about the buildroot mailing list