[Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0

[Romain Naour]

Hi Arnout, Thomas, All,

Le 25/01/2017 à 11:56, Arnout Vandecappelle a écrit :
> 
> On 24-01-17 11:33, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Sun,  8 Jan 2017 23:20:11 +0100, Romain Naour wrote:
>>> The legacy entry was missing in commit [1].
>>>
>>> [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4
>>>
>>> Signed-off-by: Romain Naour <romain.naour at gmail.com>
>>> Cc: Bernd Kuhls <bernd.kuhls at t-online.de>
>>> ---
>>>  Config.in.legacy | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/Config.in.legacy b/Config.in.legacy
>>> index 20445b8..8dfbbc8 100644
>>> --- a/Config.in.legacy
>>> +++ b/Config.in.legacy
>>> @@ -145,6 +145,13 @@ endif
>>>  ###############################################################################
>>>  comment "Legacy options removed in 2017.02"
>>>  
>>> +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX
>>> +	bool "xserver AIGLX Extension removed"
>>> +	depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17
>>> +	select BR2_LEGACY
>>> +	help
>>> +	  The xserver AIGLX Extension has been removed in 1.19.0 release.
>>
>> Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option
>> defined in two different places, with two different prompts. Do we
>> really want to do this?
> 
>  No we don't. We certainly don't want that changing some option (the server
> version) suddenly creates a legacy option.

Indeed it's annoying...

> 
>  Also, legacy is not needed here: it never was possible (in a released
> buildroot) to select this option for v1.19.0+.

...but the xserver package is special since we support several versions.
If only one version was used, this option would be removed with the bump to
1.19.0 and a legacy entry added.

If we previously used the latest xserver version (1.18.4) in 2016.11 with
BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX selected, this option will be silently
removed from the defconfig with 2017.02.

How we should handle new/old options when a package has several version available ?

Best regards,
Romain

> 
>  Regards,
>  Arnout
> 
>>
>> Cc'ing Arnout and Yann, to get their insights.
>>
>> Thanks,
>>
>> Thomas
>>
>